Skip to content

Conversation

@jhheider
Copy link
Contributor

@jhheider jhheider commented Feb 28, 2025

they have a legitimate use case for docker

see discussion beginning: https://discord.com/channels/1175095878818742316/1175095879435296820/1345155016629157888

@mxcl: i think this should follow the install/local-install split, but duplicating and de-duplicating all the sudo code felt too much for a proof-of-concept. if we like this, I can do it, however.

@jhheider jhheider force-pushed the lazy-shim branch 2 times, most recently from e1a8188 to 7737712 Compare February 28, 2025 23:16
they have a legitimate use case for docker
@jhheider jhheider marked this pull request as ready for review February 28, 2025 23:19
@jhheider jhheider requested a review from mxcl February 28, 2025 23:19
Copy link

@davireis davireis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. As though I can see the symmetry argument for both shim and local-shim, the use cases I have in mind would all be served well with shims on ~/.local/ (and not sure you want to call the command simply shim or local-shim, the former seems good enough to me).

@jhheider
Copy link
Contributor Author

jhheider commented Mar 1, 2025

if we mirrored install/local-install then shim would write to /usr/local/bin and local-shim would write to ~/.local/bin.

@davireis
Copy link

davireis commented Mar 3, 2025

if we mirrored install/local-install then shim would write to /usr/local/bin and local-shim would write to ~/.local/bin.

Yes. I have no strong feelings in either direction. Your call and let me know if I can help somehow.

@mxcl
Copy link
Member

mxcl commented Mar 10, 2025

I note that I wrote a mash script to install shims. However I don’t have a problem with this addition. Just that it is going to make formalizing a pkgm-1.0 a little trickier. Currently pkgm is a bit “whatever” and users have to accept that.

@mxcl
Copy link
Member

mxcl commented Mar 10, 2025

Needs a README update

@jhheider
Copy link
Contributor Author

Needs a README update

Done.

@felipecrs
Copy link
Contributor

Maybe a more future-proof solution would be to name the command as shim install. This would simplify later features like shim list and shim uninstall.

@felipecrs
Copy link
Contributor

Although shim (to install shims), shims (list), unshim (uninstall) also don't look bad. :)

@mxcl
Copy link
Member

mxcl commented Mar 11, 2025

If pkgx~2.4 we can use the new faster shims. Possibly not worth doing a version check. pkgm is v0 after all.

@mxcl mxcl merged commit f8afa98 into main Mar 11, 2025
3 checks passed
@jhheider
Copy link
Contributor Author

If pkgx~2.4 we can use the new faster shims. Possibly not worth doing a version check. pkgm is v0 after all.

#36

@mxcl mxcl deleted the lazy-shim branch March 11, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants